Audio always out of sync

[lostdummy]

I also have this de-sync problem, even with all US regional settings, latest version (36) and safe sync option.

I compared result with XenonMKV to one I get with original MKV, Videora (which result in correct sound, but too long file for comparable time) and GotSent (also with correct sound and even file size is similar, and time is comparable, so that was one I used at the end btw).

BUT one thing that I noticed when comparing XenonMKV result to all others (others having correct sound) is that it is not sound that is incorrect in XenonMKV, it is video that is shifted.

While video players show identical movie length (for example 2:22:55) on all results, when I use XBOX player option to go to "next chapter" (which it seems to basically divide movie without chapters to 10 equal time slices), I always get to same positions in video and audio for Videora and GotSent converted files.  When I tried for XenonMKV, I expected to get to same video positions but with audio shifted, but instead I'm getting to exact same audio positions as in other 2 conversions, but video is shifted.

[war59312]

Just had this problem as well. Seems this bug is not fixed correctly in build 36 either.

I noticed this in the log:

[3/7/2010 12:19 PM] [W]C:\Users\Will\Desktop\XboX\XenonMKV\tools\mp4box\MP4Box_default.exe "D:\XBOX\output.mp4" -add video.h264 -fps 24.24 -par 1=1:1 -add audio.m4a -tmp "D:\XBOX" -itags name="The.Cove.2009.PROPER.1080p.BluRay.x264-CiNEFiLE-1"

That should be -fps 24.000. Manually ran the command with correct -fps and it worked as it should.

Not a clue why it used 24.24 atm since mkvinfo showed fps correctly at 24.000.

[war59312]

Ouch, all Life (2009 UK version) videos are out of sync because XenonMKV uses a FPS of 25.25 instead of 25.000.

Going to have to do 35 files all manually because of this bug.

That being said, I am install Visual Studio 2010 right now to see if I can fix this myself.

[war59312]

O.K I found the bad code:

Code:

Dim fpsString As String = fpsInt & decimalPoint
            fpsString += curItem.FPS.Substring(curItem.FPS.IndexOf(".") + 1)

As you can see fpsString is "25.25" when it should be "25.000".

Also, all the values need to be xx.xxx for fps.

Working on fixing this..

Update: Seems like that is not even need.

And neither is "Dim fpsInt As Integer = Math.Floor(fpsDouble)".

Just use "Dim fpsString As String = fpsDouble".

Change:

Code:

           Dim decimalPoint As String = System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
            Dim fpsDouble As Double = Double.Parse(curItem.FPS)
            Dim fpsInt As Integer = Math.Floor(fpsDouble)
            Dim fpsString As String = fpsInt & decimalPoint
            fpsString += curItem.FPS.Substring(curItem.FPS.IndexOf(".") + 1)

            .Arguments = """" & outputFile & _
            """ -add video" & curItem.VidCodec & " -fps " & fpsString & " -par 1=" & curItem.PAR & " -add audio.m4a " & _
            "-tmp """ & tmpFolder & """ -itags name=""" & name & """"

To:

Code:

           Dim decimalPoint As String = System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
            Dim fpsDouble As Double = Double.Parse(curItem.FPS)
            Dim fpsString As String = fpsDouble

            .Arguments = """" & outputFile & _
            """ -add video" & curItem.VidCodec & " -fps " & fpsString & " -par 1=" & curItem.PAR & " -add audio.m4a " & _
            "-tmp """ & tmpFolder & """ -itags name=""" & name & """"

Problem solved.

Now all my files convert just fine. Tested with 23.976, 24.000, and 25.000 sources.

jbillo, can you confirm this does not break anything?

That is removing the two lines and simply passing fpsString as a double.

Three Example Files @ 23.976fps, 24.000fps, and 25.000fps:

http://rapidshare.com/files/380133234/Samples.zip.html

[dekks]

O.K I found the bad code:

Code:

Dim fpsString As String = fpsInt & decimalPoint
            fpsString += curItem.FPS.Substring(curItem.FPS.IndexOf(".") + 1)

As you can see fpsString is "25.25" when it should be "25.000".

Also, all the values need to be xx.xxx for fps.

Working on fixing this..

Update: Seems like that is not even need.

And neither is "Dim fpsInt As Integer = Math.Floor(fpsDouble)".

Just use "Dim fpsString As String = fpsDouble".

Change:

Code:

           Dim decimalPoint As String = System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
            Dim fpsDouble As Double = Double.Parse(curItem.FPS)
            Dim fpsInt As Integer = Math.Floor(fpsDouble)
            Dim fpsString As String = fpsInt & decimalPoint
            fpsString += curItem.FPS.Substring(curItem.FPS.IndexOf(".") + 1)

            .Arguments = """" & outputFile & _
            """ -add video" & curItem.VidCodec & " -fps " & fpsString & " -par 1=" & curItem.PAR & " -add audio.m4a " & _
            "-tmp """ & tmpFolder & """ -itags name=""" & name & """"

To:

Code:

           Dim decimalPoint As String = System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
            Dim fpsDouble As Double = Double.Parse(curItem.FPS)
            Dim fpsString As String = fpsDouble

            .Arguments = """" & outputFile & _
            """ -add video" & curItem.VidCodec & " -fps " & fpsString & " -par 1=" & curItem.PAR & " -add audio.m4a " & _
            "-tmp """ & tmpFolder & """ -itags name=""" & name & """"

Problem solved.

Now all my files convert just fine. Tested with 23.976, 24.000, and 25.000 sources.

jbillo, can you confirm this does not break anything?

That is removing the two lines and simply passing fpsString as a double.

Three Example Files @ 23.976fps, 24.000fps, and 25.000fps:

http://rapidshare.com/files/380133234/Samples.zip.html

War, would it be possible to post a binary of your changes? I am not confident in my major lack of coding knowledge to make the change and recompile myself, but kept wondering why NTSC (i.e 29fps) always looked fine but PAL/UK based shows were always out of sync.

[war59312]

Hello,

I'm not allowed to just release the binaries. I have to release the entire modified source code.

But I went ahead and uploaded the entire thing just for you.

http://rapidshare.com/files/382520790/trunk.7z

\trunk\XenonMKV\bin\Release\XenonMKV.exe

This the the binary you asked for.

You should just to be able run it without any problems.

However, if it crashes when you run it then you need to copy over your current "XenonMKV.exe.manifest" file and it should then run fine.

If it still crashes then you need to rebuild the binary yourself. Just recompile it and should be good to go.

So if you need to recompile then you must use Visual Studio 2010 since I upgraded it from 2005. Express build should work fine?

But hopefully you can just run it fine without any issues. I had to copy over the manifest file myself.

Take Care,

Will



Wow 7zip rocks!!

Edit: He-He What's the odds I take the shot right at midnight. Though notice the darn calendar on the desktop did not update. Darn bug.

[dekks]

Hello,

I'm not allowed to just release the binaries. I have to release the entire modified source code.

But I went ahead and uploaded the entire thing just for you.

http://rapidshare.com/files/382520790/trunk.7z

\trunk\XenonMKV\bin\Release\XenonMKV.exe

This the the binary you asked for.

You should just to be able run it without any problems.

However, if it crashes when you run it then you need to copy over your current "XenonMKV.exe.manifest" file and it should then run fine.

If it still crashes then you need to rebuild the binary yourself. Just recompile it and should be good to go.

So if you need to recompile then you must use Visual Studio 2010 since I upgraded it from 2005. Express build should work fine?

But hopefully you can just run it fine without any issues. I had to copy over the manifest file myself.

Take Care,

Will



Wow 7zip rocks!!

Edit: He-He What's the odds I take the shot right at midnight. Though notice the darn calendar on the desktop did not update. Darn bug.

Works like a absolute charm, have you done any other changes as it seemed to do the whole process a lot quicker than usual, around 8 mins for a 45 min MKV HD file compared to about 15 mins normally. Thanks for taking the time to put the whole thing up on rapidshare, I really appreciate it. (And of course thanks to Jake for making it in the first place).

[war59312]

Hello,

No problem. And there is no need to quote posts when you reply right after it.

It's good Forum Etiquette NOT to quote the entire post.

Please give http://www.mozilla.org/community/etiquette.html a good read.

Anyways, nope that is the only change. Though I'd recommend you update mp4box now too.

Click "Download beta" on http://www.videohelp.com/tools/mp4box to get latest build.

Then you simply extract both the dll and the exe file to XenonMKV\tools\mp4box .

Now rename the exe to "MP4Box_default", yes you want to replace the old one.

Now just make sure XenonMKV Options > Last Steps > MP4 Creation > "Use 0.4.6-dev: February 2009 (default)" is selected.

The reason it's much faster is because it's now processing the files correctly.

If you notice before some times the outputted files could be much larger than the original due to the wrong FPS.

Of course the outputted file should always be much smaller since the audio is down converted to stereo.

So basically it's much quicker because there is now a lot less data to process.

Take Care,

Will

[Belvadier]

I've done everything that war has said to do but when i try to execute the xenonmkv application it opens but when i try to convert a video it says "Exception fired: attempted to divide by zero" and doesn't progress any farther. I am very dumb with this stuff so it's likely that I just did it wrong but any help as to WHAT I might have done wrong would be helpful. I did copy over the XenonMKV.exe.manifest file and updated to the most recent mp4box...

[war59312]

Pretty sure it's an issue with the included mediainfo.exe and dll.

Please download this version https://sourceforge.net/projects/mediainfo/files/binary/mediainfo/0.7.06.4/ and extract and copy over the old ones in \XenonMKV\tools\mediainfo .

Should fix the issue.

Notice however none of the newer builds after this version work. You will get the "divide by Zero" error every time with newer builds.

I plan on figuring out why one of these days. Not much free time, so that could be months from now.. I gave it a good hour look over but could not fix it.

Though at least I found the bad code, see: http://xenonmkv.ev98.net/forum/index.php/topic,263.msg3055.html#msg3055

[Belvadier]

that worked great. No more divide by zero error and the 25fps vids I wanted to convert worked perfectly. Thanks war!

[war59312]

Sweet, glad to here my patch is working great for everyone.

Your welcome, have a good night.

[mzx]

War - Thank you so much for fixing this bug! Huge help.

[Lines]

dun know why the trunk version dont work for me. the video move to fast and out of sync same with the release version. and i think it still use wrong fps AVC-H264 import - frame size 1920 x 800 at 23976.000 FPS

[RadioHowie]

23976.000 FPS

Decimal point off by three places....might want to check your "Regional and Language" option.s